[Entity Analytics] Use docLinks service for documentation links #172172
Conversation
hop-dev
added
release_note:skip
| import { LEARN_MORE } from '../../../../overview/components/entity_analytics/risk_score/translations'; | ||
| import { useKibana } from '../../../../common/lib/kibana'; | ||
|
|
||
| const useLearnMoreLinkForEntity = (riskScoreEntity?: RiskScoreEntity) => { |
There was a problem hiding this comment.
Not necessarily a suggestion, more of a question:
Do you think there would be value in adding a test case for this, now that we're using more dynamic links instead of them just being hardcoded? I assume it would involve mocking the docLinks service, so not sure how much value we'd get, but thought I'd ask!
There was a problem hiding this comment.
I did debate testing it, but I concluded the tests would be too tied to the implementation to give much value.
There was a problem hiding this comment.
Makes sense to me!
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @hop-dev |
kibanamachine
added
v8.12.0
backport:skip
Summary
Using the docLinks service means documentation links will always point to the correct version of the docs for the current Kibana version, not just the latest docs.